Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #697
Implemented solution:
The solution relies on the search of a specific pattern for flask-based backend. First, all the possible candidates containing a
__main__.py
file are searched (original behavior), then from those candidates, the content of each of them is scanned to look for the pattern we generate from cloud harness. This avoid the inclusion of__main.py
as arguments in the case of there is some third-party libraries included for local testing purpose that also own a__main__.py
(e.g: matplotlib).How to test this PR:
To reproduce the original issue, in the folder of a workflow (e.g:
myapp
) that needs to be included in the skaffold configuration, simply add a folder hierachie like this:myfolder/mysubfolder/__main__.py
.After a generation of the skaffold configuration, the entry in the
skaffold.yml
document for theoverrides
section should be:With the fix of this PR, the right path towards the
__main__.py
of themyapp
workflow is now referenced.Sanity checks:
Breaking changes (select one):
breaking-change
Possible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):